This repository was archived by the owner on Jul 16, 2024. It is now read-only.
Ensure that denormalize input is valid. - #127
Closed
neduard wants to merge 1 commit into
Closed
Conversation
Member
|
I am hesitant to merge this. I agree with the check, but one should then have a private method denormalize without the check (and called by the obj fun and contraint) and a public method performing the check and then calling the private method. This last would be exposed/offered to the user. Could you implement this? |
|
Also, I don't think EPS is necessary here. If you want to make sure that the solution is within box |
|
I am closing this for now, feel free to submit new PR or reopen if you're still interested in committing to this! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR as per #120 (comment)
However, comparing against bound (-1.0 or 1.0) directly might cause problems when
x[i]is close to it.For example,
x[i]might be1.00000000000000001. In that case something likeif (x[i] < (-1.0 - EPS) || x[i] > (1.0 + EPS))might be recommended.How/where should
EPSbe defined though?